fix: Temperature preheat command fires at correct time within long co…#2328
Merged
Conversation
…ntinuous paths For long zigzag skin (initial layer) the temperature command was firing at the beginning of the path (start of skin) rather than at the end-ish of layer 0 (with consideration for the heat up time). The fix ensures that at the start of each path only genuinely overdue inserts are fired immediately. Inserts assigned to the current path are held until the insertTempOnTime callback reaches their time_after_path_start, preserving the intended placement regardless of how many paths the feature is split into.
Contributor
Test Results31 tests 31 ✅ 4s ⏱️ Results for commit 61126e6. ♻️ This comment has been updated with latest results. |
Remco Burema (rburema)
left a comment
Remco Burema (rburema)
left a comment
Member
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 3b6dad2 | Previous: e413060 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_local |
1.9447085998230405 ns/iter |
1.246300090173324 ns/iter |
1.56 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: Jaime van Kessel (@nallath) Jelle Spijker (@jellespijker) Erwan MATHIEU (@wawanbreton) Casper Lamboo (@casperlamboo) Saumya Jain (@saumyaj3) HellAholic
Co-authored-by: Remco Burema <41987080+rburema@users.noreply.github.com>
Remco Burema (rburema)
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For long zigzag skin (initial layer) the temperature command was firing at the beginning of the path (start of skin) rather than at the end-ish of layer 0 (with consideration for the heat up time).
The fix ensures that at the start of each path only genuinely overdue inserts are fired immediately. Inserts assigned to the current path are held until the insertTempOnTime callback reaches their time_after_path_start, preserving the intended placement regardless of how many paths the feature is split into.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist:
CURA-13115